ignore SLOW SQL QUERY critical log in all log poller tests#22128
Merged
ignore SLOW SQL QUERY critical log in all log poller tests#22128
Conversation
Contributor
Tofel
commented
Apr 22, 2026
- fix bug in load test log scanners
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW (test-only changes, but affects failure diagnostics and log-scan gating)
This PR updates devenv test log-scanning behavior to ignore expected “SLOW SQL QUERY” critical/DPanic logs in log poller tests and adjusts cleanup log scanning in some soak/load tests.
Changes:
- Centralizes an allowed log message (
ignoredSlowQueryLog) and passes it into all log poller test runners. - Updates
executeLogPollerReplayto accept allowed log messages (but currently doesn’t apply them in cleanup scanning). - Removes immediate
t.Errorreporting of log-scan errors in OCR2 soak and automation load test cleanups.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| devenv/tests/ocr2/soak_test.go | Removes early t.Error for log scan failures during cleanup. |
| devenv/tests/logpoller/logpoller_test.go | Adds shared ignored “SLOW SQL QUERY” allowed message and threads it through log poller test helpers. |
| devenv/tests/automation/load_test.go | Removes early t.Error for log scan failures during cleanup. |
Comments suppressed due to low confidence (2)
devenv/tests/automation/load_test.go:87
- With the
t.Errorremoval,scanErrwon’t causet.Failed()to be true until the finalrequire.NoError, so the log-saving branch is skipped when log scanning fails. Save container logs whenscanErr != nil(e.g.,if t.Failed() || scanErr != nil) so failures in the log scanner still capture logs for debugging.
if t.Failed() {
saveErr := framework.StreamCTFContainerLogsFanout(
framework.LogStreamConsumer{
Name: "save-container-logs",
Consume: func(logStreams map[string]io.ReadCloser) error {
_, saveErr := framework.SaveContainerLogsFromStreams(fmt.Sprintf("%s-%d", framework.DefaultCTFLogsDir, time.Now().UnixNano()), logStreams)
return saveErr
devenv/tests/ocr2/soak_test.go:52
- Removing the early
t.Errormeans a non-nilscanErrno longer marks the test as failed until the finalrequire.NoError, so theif t.Failed()branch won’t run and container logs won’t be saved for log-scan failures. Consider saving logs whenscanErr != nilas well (e.g.,if t.Failed() || scanErr != nil), and update the final error message to reflect a scan failure rather than a save failure.
if t.Failed() {
saveErr := framework.StreamCTFContainerLogsFanout(
framework.LogStreamConsumer{
Name: "save-container-logs",
Consume: func(logStreams map[string]io.ReadCloser) error {
c2bc5f6 to
59a7f4f
Compare
|
HashWrangler
approved these changes
Apr 22, 2026
erikburt
approved these changes
Apr 22, 2026
skudasov
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




